-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for medusa 1.8 @next #181
base: main
Are you sure you want to change the base?
Conversation
* chore(deps): bump @sideway/formula from 3.0.0 to 3.0.1 (#173) * fix: loaders & lint path * fix: fixes loading for 1.9 server * fix: package.json --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SGF <[email protected]>
Is this PR ready to merge? I can help test. |
I have been testing this since yesterday with latest Medusa 1.8 and Extender 1.8.8, and unless you're using custom repositories, everything seems to work. I am using pretty much all aspects of extender and the only issue I ran into with was cases where I was overrriding repositories, where I got compilation errors in the
This seems to work fine. The other issue is that extender still depends on older TypeORM which fails Great work on this!! Extender has made my life a lot easier. |
Thanks a lot 🙏 the extender will be deprecated and we are writing a migration guide to move to a full medusa set up. I keep this pr open for those who are in needs of a smooth transition 😅 hope that's fine for you. |
Hello folks, first off thank you for a great repo, I was trying to follow a previous guide in Medusa blog about how we can create a marketplace by leveraging medusa-extender, but now it looks like this is being deprecated. Does that mean if we are using medusa 1.8+, these extensions can be build on top of medusa itself? |
Hello @adrien2p , Is there an ETA on migration guide. We have alot of custom repositories we'd like to keep but running into compile time issues when upgraded to MedusaJS 1.8.1 |
you can try to use @sgftech/medusa-extender as a stop-gap arrangement if
you are not ready to migrate yet
…On Wed, 7 Jun 2023 at 16:33, Mitchell Ewulonu ***@***.***> wrote:
Hello @adrien2p <https://github.com/adrien2p> , Is there an ETA on
migration guide. We have alot of custom repositories we'd like to keep but
running into compile time issues when upgraded to MedusaJS 1.8.1
—
Reply to this email directly, view it on GitHub
<#181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXEQJHEEQIZN3MW6J3IL5QDXKBNX7ANCNFSM6AAAAAAVKS25VM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
This message (including any attachments) may contain confidential,
proprietary, privileged and/or private
information. The information is
intended to be for the use of the individual or entity designated above. If
you are not the intended recipient of this message, please notify the
sender immediately, and delete the
message and any attachments. Any
disclosure, reproduction, distribution or other use of this message or
any
attachments by an individual or entity other than the intended recipient is
prohibited.
|
WIP